content/browser/frame_host/navigation_controller_impl.h - Issue 556703004: Remove page id from FrameNavigateParams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 556703004: Remove page id from FrameNavigateParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/interstitial_page_navigator_impl.cc ('k') | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl.h

diff --git a/content/browser/frame_host/navigation_controller_impl.h b/content/browser/frame_host/navigation_controller_impl.h

index a646646f35f87d2fcf0577b33773260ca78cdca5..ff99a2727a50d739f46a5a4b1448de553e7082f7 100644

--- a/content/browser/frame_host/navigation_controller_impl.h

+++ b/content/browser/frame_host/navigation_controller_impl.h

@@ -135,6 +135,7 @@ class CONTENT_EXPORT NavigationControllerImpl

// and it will return false.

bool RendererDidNavigate(

RenderFrameHost* rfh,

+ int32 page_id,

const FrameHostMsg_DidCommitProvisionalLoad_Params& params,

LoadCommittedDetails* details);

@@ -229,6 +230,7 @@ class CONTENT_EXPORT NavigationControllerImpl

// Classifies the given renderer navigation (see the NavigationType enum).

NavigationType ClassifyNavigation(

RenderFrameHost* rfh,

+ int32 page_id,

const FrameHostMsg_DidCommitProvisionalLoad_Params& params) const;

// Causes the controller to load the specified entry. The function assumes

@@ -250,23 +252,29 @@ class CONTENT_EXPORT NavigationControllerImpl

// See LoadCommittedDetails.did_replace_entry.

void RendererDidNavigateToNewPage(

RenderFrameHost* rfh,

+ int32 page_id,

const FrameHostMsg_DidCommitProvisionalLoad_Params& params,

bool replace_entry);

void RendererDidNavigateToExistingPage(

RenderFrameHost* rfh,

+ int32 page_id,

const FrameHostMsg_DidCommitProvisionalLoad_Params& params);

void RendererDidNavigateToSamePage(

RenderFrameHost* rfh,

+ int32 page_id,

const FrameHostMsg_DidCommitProvisionalLoad_Params& params);

void RendererDidNavigateInPage(

RenderFrameHost* rfh,

+ int32 page_id,

const FrameHostMsg_DidCommitProvisionalLoad_Params& params,

bool* did_replace_entry);

void RendererDidNavigateNewSubframe(

RenderFrameHost* rfh,

+ int32 page_id,

const FrameHostMsg_DidCommitProvisionalLoad_Params& params);

bool RendererDidNavigateAutoSubframe(

RenderFrameHost* rfh,

+ int32 page_id,

const FrameHostMsg_DidCommitProvisionalLoad_Params& params);

// Helper function for code shared between Reload() and ReloadIgnoringCache().