chrome/browser/safe_browsing/client_side_detection_host.cc - Issue 556703004: Remove page id from FrameNavigateParams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host.cc

Issue 556703004: Remove page id from FrameNavigateParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/client_side_detection_host.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_host.cc b/chrome/browser/safe_browsing/client_side_detection_host.cc

index 96d8a5cc640f40b21c4bc32fe192e785c8f81cb2..8baa8ddc866ca2c97f2eec95130697ece1e25227 100644

--- a/chrome/browser/safe_browsing/client_side_detection_host.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_host.cc

@@ -393,7 +393,7 @@ void ClientSideDetectionHost::DidNavigateMainFrame(

browse_info_->url_redirects = params.redirects;

browse_info_->referrer = params.referrer.url;

browse_info_->http_status_code = details.http_status_code;

- browse_info_->page_id = params.page_id;

+ browse_info_->page_id = details.entry->GetPageID();

should_extract_malware_features_ = true;

should_classify_for_malware_ = false;