Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 556703004: Remove page id from FrameNavigateParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 // The RenderFrameHostImpl has failed to load the document. 59 // The RenderFrameHostImpl has failed to load the document.
60 virtual void DidFailLoadWithError( 60 virtual void DidFailLoadWithError(
61 RenderFrameHostImpl* render_frame_host, 61 RenderFrameHostImpl* render_frame_host,
62 const GURL& url, 62 const GURL& url,
63 int error_code, 63 int error_code,
64 const base::string16& error_description) {} 64 const base::string16& error_description) {}
65 65
66 // The RenderFrameHostImpl has committed a navigation. 66 // The RenderFrameHostImpl has committed a navigation.
67 virtual void DidNavigate( 67 virtual void DidNavigate(
68 RenderFrameHostImpl* render_frame_host, 68 RenderFrameHostImpl* render_frame_host,
69 int32 page_id,
69 const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {} 70 const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {}
70 71
71 // Called by the NavigationController to cause the Navigator to navigate 72 // Called by the NavigationController to cause the Navigator to navigate
72 // to the current pending entry. The NavigationController should be called 73 // to the current pending entry. The NavigationController should be called
73 // back with RendererDidNavigate on success or DiscardPendingEntry on failure. 74 // back with RendererDidNavigate on success or DiscardPendingEntry on failure.
74 // The callbacks can be inside of this function, or at some future time. 75 // The callbacks can be inside of this function, or at some future time.
75 // 76 //
76 // The entry has a PageID of -1 if newly created (corresponding to navigation 77 // The entry has a PageID of -1 if newly created (corresponding to navigation
77 // to a new URL). 78 // to a new URL).
78 // 79 //
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 const base::TimeTicks& renderer_before_unload_end_time) {} 149 const base::TimeTicks& renderer_before_unload_end_time) {}
149 150
150 protected: 151 protected:
151 friend class base::RefCounted<Navigator>; 152 friend class base::RefCounted<Navigator>;
152 virtual ~Navigator() {} 153 virtual ~Navigator() {}
153 }; 154 };
154 155
155 } // namespace content 156 } // namespace content
156 157
157 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 158 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_unittest.cc ('k') | content/browser/frame_host/navigator_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698