Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 556703004: Remove page id from FrameNavigateParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleaner Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 #include "content/public/browser/navigation_controller.h" 10 #include "content/public/browser/navigation_controller.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 // See http://crbug.com/78512. 65 // See http://crbug.com/78512.
66 virtual void DidRedirectProvisionalLoad( 66 virtual void DidRedirectProvisionalLoad(
67 RenderFrameHostImpl* render_frame_host, 67 RenderFrameHostImpl* render_frame_host,
68 int32 page_id, 68 int32 page_id,
69 const GURL& source_url, 69 const GURL& source_url,
70 const GURL& target_url) {} 70 const GURL& target_url) {}
71 71
72 // The RenderFrameHostImpl has committed a navigation. 72 // The RenderFrameHostImpl has committed a navigation.
73 virtual void DidNavigate( 73 virtual void DidNavigate(
74 RenderFrameHostImpl* render_frame_host, 74 RenderFrameHostImpl* render_frame_host,
75 int32 page_id,
75 const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {} 76 const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {}
76 77
77 // Called by the NavigationController to cause the Navigator to navigate 78 // Called by the NavigationController to cause the Navigator to navigate
78 // to the current pending entry. The NavigationController should be called 79 // to the current pending entry. The NavigationController should be called
79 // back with RendererDidNavigate on success or DiscardPendingEntry on failure. 80 // back with RendererDidNavigate on success or DiscardPendingEntry on failure.
80 // The callbacks can be inside of this function, or at some future time. 81 // The callbacks can be inside of this function, or at some future time.
81 // 82 //
82 // The entry has a PageID of -1 if newly created (corresponding to navigation 83 // The entry has a PageID of -1 if newly created (corresponding to navigation
83 // to a new URL). 84 // to a new URL).
84 // 85 //
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 const NavigationBeforeCommitInfo& info) {}; 128 const NavigationBeforeCommitInfo& info) {};
128 129
129 protected: 130 protected:
130 friend class base::RefCounted<Navigator>; 131 friend class base::RefCounted<Navigator>;
131 virtual ~Navigator() {} 132 virtual ~Navigator() {}
132 }; 133 };
133 134
134 } // namespace content 135 } // namespace content
135 136
136 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 137 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698