Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 556703002: Include "this" pointer in HTMLMediaElement logging. (Closed)

Created:
6 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, philipj_slow, scherkus (not reviewing), nessy, vcarbune.chromium, xhwang, Zhenyao Mo
Project:
blink
Visibility:
Public.

Description

Include "this" pointer in HTMLMediaElement logging. Needed in order to pair up constructor and destructor calls. Should be generally useful for debugging. BUG=393331, 407976 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -85 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 70 chunks +85 lines, -85 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ken Russell (switch to Gerrit)
abarth or acolwell: please review. Thanks. scherkus / xhwang: FYI. Hopefully this isn't controversial. Needed ...
6 years, 3 months ago (2014-09-09 00:42:58 UTC) #2
Ken Russell (switch to Gerrit)
+esprehn I'd like to get this in and turn it on tonight to make progress ...
6 years, 3 months ago (2014-09-09 01:53:02 UTC) #4
esprehn
lgtm
6 years, 3 months ago (2014-09-09 01:53:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/556703002/1
6 years, 3 months ago (2014-09-09 01:57:40 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 03:29:13 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 181600

Powered by Google App Engine
This is Rietveld 408576698