Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 556683003: Remove blink_asserts_always_on gyp variable. (Closed)

Created:
6 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 3 months ago
CC:
blink-reviews, jam
Project:
blink
Visibility:
Public.

Description

Remove blink_asserts_always_on gyp variable. dcheck_always_on=1 has the same effect now. BUG=411008 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M Source/build/features.gypi View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
6 years, 3 months ago (2014-09-09 01:45:31 UTC) #2
Ken Russell (switch to Gerrit)
+more reviewers
6 years, 3 months ago (2014-09-09 22:23:59 UTC) #4
abarth-chromium
lgtm
6 years, 3 months ago (2014-09-09 22:24:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/556683003/1
6 years, 3 months ago (2014-09-09 22:24:51 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 00:03:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181687

Powered by Google App Engine
This is Rietveld 408576698