Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 556603002: Fix DataReductionProxyUsageStats construction (Closed)

Created:
6 years, 3 months ago by cjhopman
Modified:
6 years, 3 months ago
Reviewers:
rpetterson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix DataReductionProxyUsageStats construction If you have the internal Chrome Android checkout and build for linux, the #ifdef around this code will be satisfied (SPDY_PROXY_AUTH_ORIGIN will be defined) but it fails to compile. NOTRY=true Committed: https://crrev.com/ea6435ffc2838fe896cf3a6f40382af2733496a7 Cr-Commit-Position: refs/heads/master@{#293789}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 7 (2 generated)
cjhopman
rlp: * https://codereview.chromium.org/556603002/diff/1/chrome/browser/profiles/profile_impl_io_data.cc File chrome/browser/profiles/profile_impl_io_data.cc (right): https://codereview.chromium.org/556603002/diff/1/chrome/browser/profiles/profile_impl_io_data.cc#newcode433 chrome/browser/profiles/profile_impl_io_data.cc:433: #if defined(SPDY_PROXY_AUTH_ORIGIN) I'm guessing we don't have ...
6 years, 3 months ago (2014-09-08 21:11:43 UTC) #2
rpetterson
LGTM https://codereview.chromium.org/556603002/diff/1/chrome/browser/profiles/profile_impl_io_data.cc File chrome/browser/profiles/profile_impl_io_data.cc (right): https://codereview.chromium.org/556603002/diff/1/chrome/browser/profiles/profile_impl_io_data.cc#newcode433 chrome/browser/profiles/profile_impl_io_data.cc:433: #if defined(SPDY_PROXY_AUTH_ORIGIN) On 2014/09/08 21:11:43, cjhopman wrote: > ...
6 years, 3 months ago (2014-09-08 21:14:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/556603002/1
6 years, 3 months ago (2014-09-08 21:24:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4c5a47b4a759179cd5a8898ecff3c26f5ebfcd9e
6 years, 3 months ago (2014-09-08 21:38:00 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:48:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea6435ffc2838fe896cf3a6f40382af2733496a7
Cr-Commit-Position: refs/heads/master@{#293789}

Powered by Google App Engine
This is Rietveld 408576698