Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 556583002: Convert GN visibility to be a list. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@master
Project:
v8
Visibility:
Public.

Description

Convert GN visibility to be a list. GN visibility currently allows either string or list types, but this is causing some problems for some templates. I'm going to require it to be lists, so am changing all callers before pushing the new binary. R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M BUILD.gn View 15 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
brettw
6 years, 3 months ago (2014-09-08 20:35:56 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-09 07:50:51 UTC) #3
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-09 08:57:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698