Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 556573004: Video capture: Remove unused declarations from VideoCaptureDevice (Closed)

Created:
6 years, 3 months ago by magjed_chromium
Modified:
6 years, 3 months ago
Reviewers:
perkj_chrome, mcasas
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video capture: Remove unused declarations from VideoCaptureDevice These functions are actually in VideoCaptureDeviceFactory. TBR=perkj@chromium.org BUG=323913 Committed: https://crrev.com/e5f9aa3cf9ab01a69431f673322e3878971e5940 Cr-Commit-Position: refs/heads/master@{#294576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M media/video/capture/video_capture_device.h View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
magjed_chromium
What's up with these unused declarations? Simple error, or something I don't understand?
6 years, 3 months ago (2014-09-11 16:13:51 UTC) #2
mcasas
LGTM. This was possibly forgotten. Can you please add crbug.com/323913 ?
6 years, 3 months ago (2014-09-12 09:36:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556573004/1
6 years, 3 months ago (2014-09-12 09:54:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10581)
6 years, 3 months ago (2014-09-12 10:02:16 UTC) #7
magjed_chromium
perkj tbr
6 years, 3 months ago (2014-09-12 11:11:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556573004/1
6 years, 3 months ago (2014-09-12 11:16:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/14936)
6 years, 3 months ago (2014-09-12 11:38:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556573004/1
6 years, 3 months ago (2014-09-12 12:20:41 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2cfa88bd8f606382e9f063cf197548ff03ec62e8
6 years, 3 months ago (2014-09-12 12:30:24 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 12:32:32 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5f9aa3cf9ab01a69431f673322e3878971e5940
Cr-Commit-Position: refs/heads/master@{#294576}

Powered by Google App Engine
This is Rietveld 408576698