Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 556543003: [Re-land] Add FontFaceDescriptors IDL dictionary (Closed)

Created:
6 years, 3 months ago by bashi
Modified:
6 years, 3 months ago
CC:
blink-reviews, arv+blink, blink-reviews-css, ed+blinkwatch_opera.com, abarth-chromium, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, darktears, apavlov+blink_chromium.org, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

This is an attempt to re-land r181610. The CL was reverted due to build breakage, but I couldn't reproduce the link error. TBR=haraken@chromium.org,keishi@chromium.org The original description: Add FontFaceDescriptors IDL dictionary To follow the spec[1]. This is the first place to use IDL dictionary execept for testing, so this CL also includes build related changes. Existing tests(e.g. fast/css/fontface-constructor-error.html) should cover this change. [1] http://dev.w3.org/csswg/css-font-loading/#fontface-interface BUG=403150 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181610 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181631

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -56 lines) Patch
M Source/bindings/core/idl.gni View 2 chunks +6 lines, -2 lines 0 comments Download
M Source/bindings/core/idl.gypi View 3 chunks +8 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/BUILD.gn View 2 chunks +4 lines, -7 lines 0 comments Download
M Source/bindings/core/v8/generated.gyp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/core.gni View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/core.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +7 lines, -12 lines 0 comments Download
M Source/core/css/FontFace.h View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/css/FontFace.cpp View 5 chunks +11 lines, -18 lines 0 comments Download
M Source/core/css/FontFace.idl View 1 chunk +3 lines, -3 lines 0 comments Download
A Source/core/css/FontFaceDescriptors.idl View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bashi
6 years, 3 months ago (2014-09-09 08:43:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/556543003/1
6 years, 3 months ago (2014-09-09 08:44:11 UTC) #4
haraken
LGTM
6 years, 3 months ago (2014-09-09 08:47:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 181631
6 years, 3 months ago (2014-09-09 10:31:39 UTC) #6
keishi
On 2014/09/09 10:31:39, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 3 months ago (2014-09-09 11:05:27 UTC) #7
bashi
6 years, 3 months ago (2014-09-09 11:13:51 UTC) #8
Message was sent while issue was closed.
On 2014/09/09 11:05:27, keishi wrote:
> On 2014/09/09 10:31:39, I haz the power (commit-bot) wrote:
> > Committed patchset #1 (id:1) as 181631
> 
> The first build after it landed failed again
>
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/buil...
> But it seems to have succeeded on its second try, so I think it is ok.
>
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/buil...
> 
> Sorry for the trouble.

Thank you for handling the trouble! Feel free to re-revert if needed:)

Powered by Google App Engine
This is Rietveld 408576698