Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 556533002: [NaCl SDK] nacl_io: seperate socket syscalls into thier own directory. (Closed)

Created:
6 years, 3 months ago by Sam Clegg
Modified:
6 years, 3 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: seperate socket syscalls into thier own directory. This change contains only renames. It allows us to distingish between socket syscalls and others syscall overrides, which helps us to identify overrides that we should be aiming to eliminate. Committed: https://crrev.com/2fe81bc37a2da88b2fd7cc94360435cb98d16cdf Cr-Commit-Position: refs/heads/master@{#293840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -808 lines) Patch
M native_client_sdk/src/libraries/nacl_io/library.dsc View 1 chunk +33 lines, -33 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/accept.c View 1 chunk +0 lines, -14 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/bind.c View 1 chunk +0 lines, -14 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/connect.c View 1 chunk +0 lines, -14 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/freeaddrinfo.c View 1 chunk +0 lines, -9 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/gai_strerror.c View 1 chunk +0 lines, -35 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/getaddrinfo.c View 1 chunk +0 lines, -12 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/gethostbyname.c View 1 chunk +0 lines, -16 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/getnameinfo.c View 1 chunk +0 lines, -20 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/getpeername.c View 1 chunk +0 lines, -14 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/getsockname.c View 1 chunk +0 lines, -14 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/getsockopt.c View 1 chunk +0 lines, -14 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/herror.c View 1 chunk +0 lines, -19 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/hstrerror.c View 1 chunk +0 lines, -31 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/htonl.c View 1 chunk +0 lines, -23 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/htons.c View 1 chunk +0 lines, -21 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/inet_addr.c View 1 chunk +0 lines, -20 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/inet_aton.c View 1 chunk +0 lines, -55 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/inet_ntoa.c View 1 chunk +0 lines, -22 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/inet_ntop.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/inet_pton.c View 1 chunk +0 lines, -147 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/listen.c View 1 chunk +0 lines, -14 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/ntohl.c View 1 chunk +0 lines, -21 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/ntohs.c View 1 chunk +0 lines, -19 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/recv.c View 1 chunk +0 lines, -14 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/recvfrom.c View 1 chunk +0 lines, -15 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/recvmsg.c View 1 chunk +0 lines, -14 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/send.c View 1 chunk +0 lines, -14 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/sendmsg.c View 1 chunk +0 lines, -14 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/sendto.c View 1 chunk +0 lines, -15 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/setsockopt.c View 1 chunk +0 lines, -15 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/shutdown.c View 1 chunk +0 lines, -14 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/socket.c View 1 chunk +0 lines, -14 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/accept.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/bind.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/connect.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/freeaddrinfo.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/gai_strerror.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/getaddrinfo.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/gethostbyname.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/getnameinfo.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/getpeername.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/getsockname.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/getsockopt.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/herror.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/hstrerror.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/htonl.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/htons.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/inet_addr.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/inet_aton.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/inet_ntoa.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/inet_ntop.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/inet_pton.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/listen.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/ntohl.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/ntohs.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/recv.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/recvfrom.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/recvmsg.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/send.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/sendmsg.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/sendto.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/setsockopt.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/shutdown.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/socket.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + native_client_sdk/src/libraries/nacl_io/syscalls/socket/socketpair.c View 0 chunks +-1 lines, --1 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/socketpair.c View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam Clegg
6 years, 3 months ago (2014-09-08 18:42:09 UTC) #2
binji
lgtm
6 years, 3 months ago (2014-09-08 18:50:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/556533002/1
6 years, 3 months ago (2014-09-08 23:21:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ea413c1dfd4092df4b6855207a1a655118c1118e
6 years, 3 months ago (2014-09-09 02:54:53 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:49:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fe81bc37a2da88b2fd7cc94360435cb98d16cdf
Cr-Commit-Position: refs/heads/master@{#293840}

Powered by Google App Engine
This is Rietveld 408576698