Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 556493002: Video Player: Resume the playback position on launch (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video Player: Resume the playback position on launch Before, the specified playback position was ignored so this patch fixes the bug. BUG=395868 Committed: https://crrev.com/eacfb1e956b21f10742bf50273ed399e05154593 Cr-Commit-Position: refs/heads/master@{#294350}

Patch Set 1 #

Patch Set 2 : Add a JSdoc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/file_manager/file_manager/audio_player/js/audio_player.js View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
yoshiki
@fukino-san, PTAL. Thanks.
6 years, 3 months ago (2014-09-11 04:31:51 UTC) #2
fukino
On 2014/09/11 04:31:51, yoshiki wrote: > @fukino-san, PTAL. Thanks. lgtm.
6 years, 3 months ago (2014-09-11 06:15:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556493002/20001
6 years, 3 months ago (2014-09-11 06:47:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ca360820226de3efc15e7bc699c0c8c72eb04630
6 years, 3 months ago (2014-09-11 07:55:33 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 08:19:18 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/eacfb1e956b21f10742bf50273ed399e05154593
Cr-Commit-Position: refs/heads/master@{#294350}

Powered by Google App Engine
This is Rietveld 408576698