extensions/renderer/set_icon_natives.cc - Issue 556463002: Revert of tryAllocPixels returns bool, allocPixels requires success

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/set_icon_natives.cc

Issue 556463002: Revert of tryAllocPixels returns bool, allocPixels requires success (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/set_icon_natives.cc

diff --git a/extensions/renderer/set_icon_natives.cc b/extensions/renderer/set_icon_natives.cc

index ffdd6aaef4b478809f1c8478935893b46600ff79..4fcec19f36589de6d80e18b05473fc4dfc6694a3 100644

--- a/extensions/renderer/set_icon_natives.cc

+++ b/extensions/renderer/set_icon_natives.cc

@@ -69,7 +69,7 @@

}

SkBitmap bitmap;

- if (!bitmap.tryAllocN32Pixels(width, height)) {

+ if (!bitmap.allocN32Pixels(width, height)) {

isolate->ThrowException(

v8::Exception::Error(v8::String::NewFromUtf8(isolate, kNoMemory)));

return false;

« no previous file with comments | « content/renderer/skia_benchmarking_extension.cc ('k') | media/filters/skcanvas_video_renderer_unittest.cc » ('j') | no next file with comments »