content/browser/android/system_ui_resource_manager_impl.cc - Issue 556463002: Revert of tryAllocPixels returns bool, allocPixels requires success

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/system_ui_resource_manager_impl.cc

Issue 556463002: Revert of tryAllocPixels returns bool, allocPixels requires success (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/table_row_nsimage_cache_unittest.mm ('k') | content/browser/compositor/delegated_frame_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/system_ui_resource_manager_impl.cc

diff --git a/content/browser/android/system_ui_resource_manager_impl.cc b/content/browser/android/system_ui_resource_manager_impl.cc

index dfbbc5aeb6d81958e8838162d8fa77d036559b93..81f12fc3a70d5d0abde50158258001d4343c7564 100644

--- a/content/browser/android/system_ui_resource_manager_impl.cc

+++ b/content/browser/android/system_ui_resource_manager_impl.cc

@@ -40,7 +40,11 @@

SkRect arc_rect = SkRect::MakeXYWH(

-arc_width / 2.f, -arc_width - y, arc_width * 2.f, arc_width * 2.f);

SkBitmap glow_bitmap;

- glow_bitmap.allocPixels(SkImageInfo::MakeA8(bounds.width(), bounds.height()));

+ if (!glow_bitmap.allocPixels(

+ SkImageInfo::MakeA8(bounds.width(), bounds.height()))) {

+ LOG(FATAL) << " Failed to allocate bitmap of size " << bounds.width() << "x"

+ << bounds.height();

+ }

glow_bitmap.eraseColor(SK_ColorTRANSPARENT);

SkCanvas canvas(glow_bitmap);

« no previous file with comments | « chrome/browser/ui/cocoa/table_row_nsimage_cache_unittest.mm ('k') | content/browser/compositor/delegated_frame_host.cc » ('j') | no next file with comments »