chrome/browser/themes/browser_theme_pack.cc - Issue 556463002: Revert of tryAllocPixels returns bool, allocPixels requires success

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/browser_theme_pack.cc

Issue 556463002: Revert of tryAllocPixels returns bool, allocPixels requires success (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_conversion_helper.cc ('k') | chrome/browser/ui/app_list/fast_show_pickler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/themes/browser_theme_pack.cc

diff --git a/chrome/browser/themes/browser_theme_pack.cc b/chrome/browser/themes/browser_theme_pack.cc

index 9610340efecb7da47ead869b117e17cd30112994..7787fc0d290a4dd38c82e40f8c2a615a70613dd2 100644

--- a/chrome/browser/themes/browser_theme_pack.cc

+++ b/chrome/browser/themes/browser_theme_pack.cc

@@ -477,7 +477,8 @@

ui::GetScaleForScaleFactor(desired_scale_factor) /

ui::GetScaleForScaleFactor(source_scale_factor)));

SkBitmap scaled_bitmap;

- scaled_bitmap.allocN32Pixels(scaled_size.width(), scaled_size.height());

+ if (!scaled_bitmap.allocN32Pixels(scaled_size.width(), scaled_size.height()))

+ SK_CRASH();

scaled_bitmap.eraseARGB(0, 0, 0, 0);

SkCanvas canvas(scaled_bitmap);

SkRect scaled_bounds = RectToSkRect(gfx::Rect(scaled_size));

« no previous file with comments | « chrome/browser/notifications/notification_conversion_helper.cc ('k') | chrome/browser/ui/app_list/fast_show_pickler.cc » ('j') | no next file with comments »