Issue 556453008: Fix perf jitdump integration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 556453008: Fix perf jitdump integration. (Closed)

Created:
6 years, 3 months ago by Vyacheslav Egorov (Google)

Modified:
6 years, 3 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix perf jitdump integration. When emitting JIT_CODE_LOAD for Crankshafted code exclude Safepoint Table from the size of the code. This cleans up perf annotate output - because otherwise it confusingly tries to disassemble safepoint table. R=jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23814

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/perf-jit.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

6 years, 3 months ago (2014-09-09 17:35:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23814 (presubmit successful).

Expand Messages | Collapse Messages