Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 556453007: Make slider thumb painting bail out when the node is null. (Closed)

Created:
6 years, 3 months ago by jbroman
Modified:
6 years, 3 months ago
Reviewers:
tkent, dglazkov, eseidel
CC:
blink-reviews, blink-reviews-rendering, zoltan1, philipj_slow, eae+blinkwatch, leviw+renderwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Make slider thumb painting bail out when the node is null. The other media control painting methods do handle a null node in toParentMediaElement (as can happen with a pseudo-element, such as ::-webkit-scrollbar). The slider thumb painting should too. There are currently unfounded assertions that this node is not null, but author style can make it null, so a proper check is appropriate. A layout test has been added for this case. BUG=412154 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
A LayoutTests/media/controls-slider-appearance-crash.html View 1 chunk +30 lines, -0 lines 0 comments Download
A + LayoutTests/media/controls-slider-appearance-crash-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/rendering/RenderMediaControls.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbroman
6 years, 3 months ago (2014-09-09 15:13:29 UTC) #2
eseidel
lgtm
6 years, 3 months ago (2014-09-09 15:18:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/556453007/1
6 years, 3 months ago (2014-09-09 15:18:45 UTC) #5
eseidel
These are specifically "anonymous renderers" any renderer w/o an associated node is "anonymous". It's easy ...
6 years, 3 months ago (2014-09-09 15:19:01 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 16:11:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181656

Powered by Google App Engine
This is Rietveld 408576698