Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 556453005: Added component dir to bindings tests for binding modularization. (Closed)

Created:
6 years, 3 months ago by tasak
Modified:
6 years, 3 months ago
Reviewers:
haraken, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Added component dir to bindings tests for binding modularization. Moved all test idl files into Source/bindings/tests/idls/core. Added one new idl file (TestPartialInterface3) into Source/bindings/tests/idls/modules. BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -1791 lines) Patch
D Source/bindings/tests/idls/SVGTestInterface.idl View 1 chunk +0 lines, -39 lines 0 comments Download
D Source/bindings/tests/idls/TestCallbackInterface.idl View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/bindings/tests/idls/TestDictionary.idl View 1 chunk +0 lines, -20 lines 0 comments Download
D Source/bindings/tests/idls/TestException.idl View 1 chunk +0 lines, -38 lines 0 comments Download
D Source/bindings/tests/idls/TestImplements.idl View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/bindings/tests/idls/TestImplements2.idl View 1 chunk +0 lines, -41 lines 0 comments Download
D Source/bindings/tests/idls/TestImplements3.idl View 1 chunk +0 lines, -14 lines 0 comments Download
D Source/bindings/tests/idls/TestInterface.idl View 1 chunk +0 lines, -95 lines 0 comments Download
D Source/bindings/tests/idls/TestInterface2.idl View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/bindings/tests/idls/TestInterface3.idl View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceCheckSecurity.idl View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceConstructor.idl View 1 chunk +0 lines, -50 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceConstructor2.idl View 1 chunk +0 lines, -51 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceConstructor3.idl View 1 chunk +0 lines, -35 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceConstructor4.idl View 1 chunk +0 lines, -11 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceCustomConstructor.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceDocument.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceEmpty.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceEventConstructor.idl View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceEventTarget.idl View 1 chunk +0 lines, -35 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceGarbageCollected.idl View 1 chunk +0 lines, -11 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl View 1 chunk +0 lines, -45 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceNamedConstructor2.idl View 1 chunk +0 lines, -35 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceNode.idl View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceNotScriptWrappable.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D Source/bindings/tests/idls/TestInterfaceWillBeGarbageCollected.idl View 1 chunk +0 lines, -38 lines 0 comments Download
D Source/bindings/tests/idls/TestNode.idl View 1 chunk +0 lines, -29 lines 0 comments Download
D Source/bindings/tests/idls/TestObject.idl View 1 chunk +0 lines, -557 lines 0 comments Download
D Source/bindings/tests/idls/TestPartialInterface.idl View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/bindings/tests/idls/TestPartialInterface2.idl View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/bindings/tests/idls/TestSpecialOperations.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D Source/bindings/tests/idls/TestSpecialOperationsNotEnumerable.idl View 1 chunk +0 lines, -8 lines 0 comments Download
D Source/bindings/tests/idls/TestTypedefs.idl View 1 chunk +0 lines, -63 lines 0 comments Download
A + Source/bindings/tests/idls/core/SVGTestInterface.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestCallbackInterface.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestDictionary.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestException.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestImplements.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestImplements2.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestImplements3.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterface.idl View 1 chunk +3 lines, -0 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterface2.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterface3.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceCheckSecurity.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceConstructor.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceConstructor2.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceConstructor3.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceConstructor4.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceCustomConstructor.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceDocument.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceEmpty.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceEventConstructor.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceEventTarget.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceGarbageCollected.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceNamedConstructor.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceNamedConstructor2.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceNode.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceNotScriptWrappable.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestInterfaceWillBeGarbageCollected.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestNode.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestObject.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestPartialInterface.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestPartialInterface2.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestSpecialOperations.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestSpecialOperationsNotEnumerable.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/core/TestTypedefs.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/tests/idls/modules/TestPartialInterface3.idl View 1 chunk +10 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/TestDictionary.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestCallbackInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestDictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestException.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 12 chunks +224 lines, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface2.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface3.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor4.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceGarbageCollected.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNotScriptWrappable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperations.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.h View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 2 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tasak
Would you review this CL? I found a bug of method overloads with PerContextEnabled. c.f. ...
6 years, 3 months ago (2014-09-09 07:47:39 UTC) #2
haraken
LGTM
6 years, 3 months ago (2014-09-09 07:57:50 UTC) #3
bashi
Could you elaborate why we want to do this in the description? Also, shouldn't we ...
6 years, 3 months ago (2014-09-09 08:00:47 UTC) #4
tasak
On 2014/09/09 08:00:47, bashi1 wrote: > Could you elaborate why we want to do this ...
6 years, 3 months ago (2014-09-09 09:23:22 UTC) #5
bashi
On 2014/09/09 09:23:22, tasak wrote: > On 2014/09/09 08:00:47, bashi1 wrote: > > Could you ...
6 years, 3 months ago (2014-09-09 09:24:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/556453005/1
6 years, 3 months ago (2014-09-09 09:25:19 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 10:26:22 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181630

Powered by Google App Engine
This is Rietveld 408576698