Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 556453004: Web Animations: Use null for unresolved startTime and currentTime in AnimationPlayer (Closed)

Created:
6 years, 3 months ago by dstockwell
Modified:
6 years, 3 months ago
CC:
darktears, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, Inactive, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Project:
blink
Visibility:
Public.

Description

Web Animations: Use null for unresolved startTime and currentTime in AnimationPlayer BUG=396372 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181704

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Simplify logic #

Patch Set 4 : Revert formatting change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
A LayoutTests/web-animations-api/player-unresolved-times.html View 1 chunk +17 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayer.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dstockwell
6 years, 3 months ago (2014-09-10 01:58:47 UTC) #2
alancutter (OOO until 2018)
The spec discussion linked to in the bug mentions using NaN instead of null for ...
6 years, 3 months ago (2014-09-10 02:09:01 UTC) #3
dstockwell
On 2014/09/10 at 02:09:01, alancutter wrote: > The spec discussion linked to in the bug ...
6 years, 3 months ago (2014-09-10 02:11:16 UTC) #4
alancutter (OOO until 2018)
lgtm
6 years, 3 months ago (2014-09-10 02:16:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/556453004/60001
6 years, 3 months ago (2014-09-10 04:12:01 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 06:15:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 181704

Powered by Google App Engine
This is Rietveld 408576698