[Telemetry] Move page logic into page/__init__.py.

[Telemetry] Move page logic into page/__init__.py.

The Page class was being declared in page/page.py which was creating problems
for several module-level functions handling pages which were being declared
(CL to follow). This CL kills page.py and moves the associated logic into
page/__init__.py, in line with e.g. value/.

R=dtu,nednguyen,chrishenry

Committed: https://crrev.com/5643db88e9327ae23c36e2acde1778cc171dbeb2
Cr-Commit-Position: refs/heads/master@{#296899}

[eakuefner, 2014-09-08 16:39:57]

Simple refactoring change that blocks some changes I have in the pipe.

Note that two of the record_wpr unittests are failing; they're failing on master
as well for reasons unrelated to this refactor.

[nduca, 2014-09-08 18:39:32]

nduca@chromium.org changed reviewers:
+ nduca@chromium.org

[nduca, 2014-09-08 18:39:33]

this makes sense, lgtm

[nednguyen, 2014-09-08 18:45:52]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2014-09-08 18:45:52]

lgtm

[nednguyen, 2014-09-08 18:46:47]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2014-09-08 18:49:13]

Actually, you will need to modify all the page module references in
perf/page_sets/ and other places as well. I think you can get around the huge
changes by keeping page.py there and add the import Page class from __init__. 

After the conversion, then page.py can die.

[dtu, 2014-09-08 20:28:18]

On 2014/09/08 18:49:13, nednguyen wrote:
> Actually, you will need to modify all the page module references in
> perf/page_sets/ and other places as well. I think you can get around the huge
> changes by keeping page.py there and add the import Page class from __init__. 
> 
> After the conversion, then page.py can die.

lgtm % fixing the references. I think record_wpr_unittests is failing on
--browser=system because of some options plumbing issue.

[chrishenry, 2014-09-10 00:44:34]

lgtm, but please address Ned's comment.

https://codereview.chromium.org/556453003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/page/__init__.py (right):

https://codereview.chromium.org/556453003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/__init__.py:4: import inspect
(Is copy detection screwing up? Can you adjust the copy detection %age in git cl
upload until it properly detects a copy? Can't remember the flag name, but you
can take a look at git cl help upload.)

[eakuefner, 2014-09-25 22:36:28]

On 2014/09/10 at 00:44:34, chrishenry wrote:
> lgtm, but please address Ned's comment.
> 
>
https://codereview.chromium.org/556453003/diff/20001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/page/__init__.py (right):
> 
>
https://codereview.chromium.org/556453003/diff/20001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/page/__init__.py:4: import inspect
> (Is copy detection screwing up? Can you adjust the copy detection %age in git
cl upload until it properly detects a copy? Can't remember the flag name, but
you can take a look at git cl help upload.)

I can't get copy detection to work, but I have fixed page.py according to Ned.
Can I land this?

[nednguyen, 2014-09-25 23:20:56]

On 2014/09/25 22:36:28, eakuefner wrote:
> On 2014/09/10 at 00:44:34, chrishenry wrote:
> > lgtm, but please address Ned's comment.
> > 
> >
>
https://codereview.chromium.org/556453003/diff/20001/tools/telemetry/telemetr...
> > File tools/telemetry/telemetry/page/__init__.py (right):
> > 
> >
>
https://codereview.chromium.org/556453003/diff/20001/tools/telemetry/telemetr...
> > tools/telemetry/telemetry/page/__init__.py:4: import inspect
> > (Is copy detection screwing up? Can you adjust the copy detection %age in
git
> cl upload until it properly detects a copy? Can't remember the flag name, but
> you can take a look at git cl help upload.)
> 
> I can't get copy detection to work, but I have fixed page.py according to Ned.
> Can I land this?

Copy detection:

  --similarity=SIM      Sets the percentage that a pair of files need to match
                        in order to be considered copies (default 50)

[eakuefner, 2014-09-26 05:29:14]

On 2014/09/25 at 23:20:56, nednguyen wrote:
> On 2014/09/25 22:36:28, eakuefner wrote:
> > On 2014/09/10 at 00:44:34, chrishenry wrote:
> > > lgtm, but please address Ned's comment.
> > > 
> > >
> >
https://codereview.chromium.org/556453003/diff/20001/tools/telemetry/telemetr...
> > > File tools/telemetry/telemetry/page/__init__.py (right):
> > > 
> > >
> >
https://codereview.chromium.org/556453003/diff/20001/tools/telemetry/telemetr...
> > > tools/telemetry/telemetry/page/__init__.py:4: import inspect
> > > (Is copy detection screwing up? Can you adjust the copy detection %age in
git
> > cl upload until it properly detects a copy? Can't remember the flag name,
but
> > you can take a look at git cl help upload.)
> > 
> > I can't get copy detection to work, but I have fixed page.py according to
Ned.
> > Can I land this?
> 
> Copy detection:
> 
>   --similarity=SIM      Sets the percentage that a pair of files need to match
>                         in order to be considered copies (default 50)

Right, I tried lowering the similarity and it still didn't work.

[chrishenry, 2014-09-26 05:35:20]

lgtm

Yah, because it's not a copy. __init__.py already exists (kind of obvious in
retrospect - sorry). Feel free to submit.

[eakuefner, 2014-09-26 05:44:23]

The CQ bit was checked by eakuefner@chromium.org

[commit-bot: I haz the power, 2014-09-26 05:45:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/556453003/40001

[commit-bot: I haz the power, 2014-09-26 06:51:23]

Committed patchset #3 (id:40001) as 1c6573a9222bb1a64d63ab6c540f7a79412d35be

[commit-bot: I haz the power, 2014-09-26 06:52:22]

Patchset 3 (id:??) landed as
https://crrev.com/5643db88e9327ae23c36e2acde1778cc171dbeb2
Cr-Commit-Position: refs/heads/master@{#296899}