Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 556433002: fail when coincidence is too far apart (Closed)

Created:
6 years, 3 months ago by caryclark
Modified:
6 years, 3 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

fail when coincidence is too far apart TBR= BUG=410552 Committed: https://skia.googlesource.com/skia/+/361b8b088589748e4b29895a4ebc5316e881e219

Patch Set 1 #

Patch Set 2 : fail on angles that have zero length spans #

Patch Set 3 : factor out common exception code #

Patch Set 4 : fix comment #

Patch Set 5 : merge fix from trunk for issue 410552 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -19 lines) Patch
M src/pathops/SkOpContour.cpp View 1 2 3 5 chunks +19 lines, -18 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 3 4 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/556433002/60001
6 years, 3 months ago (2014-09-08 17:09:47 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 17:25:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 361b8b088589748e4b29895a4ebc5316e881e219

Powered by Google App Engine
This is Rietveld 408576698