cherry pick to fix memory leak

pkg/web_components/lib/platform.concat.js

-/**
- * Copyright (c) 2014 The Polymer Project Authors. All rights reserved.

[Siggi Cherem (dart-lang), 2014/09/10 22:13:52]

seems odd that this part is removed?

[jakemac, 2014/09/10 22:37:43]

fixed

- * This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
- * The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
- * The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
- * Code distributed by Google as part of the polymer project is also
- * subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
- */
-
-window.Platform = window.Platform || {};
-// prepopulate window.logFlags if necessary
-window.logFlags = window.logFlags || {};
-// process flags
-(function(scope){
-  // import
-  var flags = scope.flags || {};
-  // populate flags from location
-  location.search.slice(1).split('&').forEach(function(o) {
-    o = o.split('=');
-    o[0] && (flags[o[0]] = o[1] || true);
-  });
-  var entryPoint = document.currentScript ||
-      document.querySelector('script[src*="platform.js"]');
-  if (entryPoint) {
-    var a = entryPoint.attributes;
-    for (var i = 0, n; i < a.length; i++) {
-      n = a[i];
-      if (n.name !== 'src') {
-        flags[n.name] = n.value || true;
-      }
-    }
-  }
-  if (flags.log) {
-    flags.log.split(',').forEach(function(f) {
-      window.logFlags[f] = true;
-    });
-  }
-  // If any of these flags match 'native', then force native ShadowDOM; any
-  // other truthy value, or failure to detect native
-  // ShadowDOM, results in polyfill
-  flags.shadow = flags.shadow || flags.shadowdom || flags.polyfill;
-  if (flags.shadow === 'native') {
-    flags.shadow = false;
-  } else {
-    flags.shadow = flags.shadow || !HTMLElement.prototype.createShadowRoot;
-  }
-
-  if (flags.shadow && document.querySelectorAll('script').length > 1) {
-    console.warn('platform.js is not the first script on the page. ' +
-        'See http://www.polymer-project.org/docs/start/platform.html#setup ' +
-        'for details.');
-  }
-
-  // CustomElements polyfill flag
-  if (flags.register) {
-    window.CustomElements = window.CustomElements || {flags: {}};
-    window.CustomElements.flags.register = flags.register;
-  }
-
-  if (flags.imports) {
-    window.HTMLImports = window.HTMLImports || {flags: {}};
-    window.HTMLImports.flags.imports = flags.imports;
-  }
-
-  // export
-  scope.flags = flags;
-})(Platform);
-
 /*
  * Copyright 2012 The Polymer Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style
  * license that can be found in the LICENSE file.
  */
 
 if (typeof WeakMap === 'undefined') {
   (function() {
     var defineProperty = Object.defineProperty;
     var counter = Date.now() % 1e9;
@@ skipping 26 matching lines @@
         var entry = key[this.name];
         if (!entry) return false;
         return entry[0] === key;
       }
     };
 
     window.WeakMap = WeakMap;
   })();
 }
 
-// select ShadowDOM impl
-if (Platform.flags.shadow) {
-
 // Copyright 2012 Google Inc.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 2192 matching lines @@
   'use strict';
 
   var setEndOfMicrotask = scope.setEndOfMicrotask
   var wrapIfNeeded = scope.wrapIfNeeded
   var wrappers = scope.wrappers;
 
   var registrationsTable = new WeakMap();
   var globalMutationObservers = [];
   var isScheduled = false;
 
-  function scheduleCallback(observer) {
+  function scheduleCallback() {
     if (isScheduled)
       return;
     setEndOfMicrotask(notifyObservers);
     isScheduled = true;
   }
 
   // http://dom.spec.whatwg.org/#mutation-observers
   function notifyObservers() {
     isScheduled = false;
 
-    do {
-      var notifyList = globalMutationObservers.slice();
-      var anyNonEmpty = false;
+    while (globalMutationObservers.length) {
+      var notifyList = globalMutationObservers;
+      globalMutationObservers = [];
+
+      // Deliver changes in birth order of the MutationObservers.
+      notifyList.sort(function(x, y) { return x.uid_ - y.uid_; });
+
       for (var i = 0; i < notifyList.length; i++) {
         var mo = notifyList[i];
         var queue = mo.takeRecords();
         removeTransientObserversFor(mo);
         if (queue.length) {
           mo.callback_(queue, mo);
-          anyNonEmpty = true;
         }
       }
-    } while (anyNonEmpty);
+    }
   }
 
+
   /**
    * @param {string} type
    * @param {Node} target
    * @constructor
    */
   function MutationRecord(type, target) {
     this.type = type;
     this.target = target;
     this.addedNodes = new wrappers.NodeList();
     this.removedNodes = new wrappers.NodeList();
@@ skipping 85 matching lines @@
         // true, or type is "characterData" and options's characterDataOldValue
         // is true, set the paired string of registered observer's observer in
         // interested observers to oldValue.
         if (type === 'attributes' && options.attributeOldValue ||
             type === 'characterData' && options.characterDataOldValue) {
           associatedStrings[observer.uid_] = data.oldValue;
         }
       }
     }
 
-    var anyRecordsEnqueued = false;
+    var anyObserversEnqueued = false;
 
     // 4.
     for (var uid in interestedObservers) {
       var observer = interestedObservers[uid];
       var record = new MutationRecord(type, target);
 
       // 2.
       if ('name' in data && 'namespace' in data) {
         record.attributeName = data.name;
         record.attributeNamespace = data.namespace;
@@ skipping 13 matching lines @@
 
       // 6.
       if (data.nextSibling)
         record.nextSibling = data.nextSibling;
 
       // 7.
       if (associatedStrings[uid] !== undefined)
         record.oldValue = associatedStrings[uid];
 
       // 8.
+      if (!observer.records_.length) {
+        globalMutationObservers.push(observer);
+        anyObserversEnqueued = true;
+      }
       observer.records_.push(record);
-
-      anyRecordsEnqueued = true;
     }
 
-    if (anyRecordsEnqueued)
+    if (anyObserversEnqueued)
       scheduleCallback();
   }
 
   var slice = Array.prototype.slice;
 
   /**
    * @param {!Object} options
    * @constructor
    */
   function MutationObserverOptions(options) {
@@ skipping 43 matching lines @@
   /**
    * The class that maps to the DOM MutationObserver interface.
    * @param {Function} callback.
    * @constructor
    */
   function MutationObserver(callback) {
     this.callback_ = callback;
     this.nodes_ = [];
     this.records_ = [];
     this.uid_ = ++uidCounter;
-
-    // This will leak. There is no way to implement this without WeakRefs :'(
-    globalMutationObservers.push(this);
   }
 
   MutationObserver.prototype = {
     constructor: MutationObserver,
 
     // http://dom.spec.whatwg.org/#dom-mutationobserver-observe
     observe: function(target, options) {
       target = wrapIfNeeded(target);
 
       var newOptions = new MutationObserverOptions(options);
@@ skipping 6299 matching lines @@
 
     }
   });
 }
 
 // exports
 scope.ShadowCSS = ShadowCSS;
 
 })(window.Platform);
 
-} else {
 /*
  * Copyright (c) 2014 The Polymer Project Authors. All rights reserved.
  * This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
  * The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
  * The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
  * Code distributed by Google as part of the polymer project is also
  * subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
  */
 
 (function(scope) {
 
   // so we can call wrap/unwrap without testing for ShadowDOMPolyfill
   window.wrap = window.unwrap = function(n){
     return n;
   }
 
   addEventListener('DOMContentLoaded', function() {
     if (CustomElements.useNative === false) {
       var originalCreateShadowRoot = Element.prototype.createShadowRoot;
       Element.prototype.createShadowRoot = function() {
         var root = originalCreateShadowRoot.call(this);
         CustomElements.watchShadow(this);
         return root;
       };
     }
   });
 
 })(window.Platform);
 
-}
 /* Any copyright is dedicated to the Public Domain.
  * http://creativecommons.org/publicdomain/zero/1.0/ */
 
 (function(scope) {
   'use strict';
 
   // feature detect for URL constructor
   var hasWorkingUrl = false;
   if (!scope.forceJURL) {
     try {
@@ skipping 3327 matching lines @@
   // exports
 
   scope.marshal = marshal;
   // `module` confuses commonjs detectors
   scope.modularize = module;
   scope.using = using;
 
 })(window);
 
 //# sourceMappingURL=platform.concat.js.map