Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 556403002: cros: Enable Drive apps integration in app launcher. (Closed)

Created:
6 years, 3 months ago by xiyuan
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cros: Enable Drive apps integration in app launcher. BUG=412954 Committed: https://crrev.com/fde6f25b66d632e49751365559841c1e1c436856 Cr-Commit-Position: refs/heads/master@{#294610}

Patch Set 1 #

Patch Set 2 : flip enable flag to disable instead of removing it #

Patch Set 3 : rebase, fix test #

Patch Set 4 : update histograms.xml #

Total comments: 2

Patch Set 5 : restore enable-drive-apps-in-app-list in histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_provider_browsertest.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/app_list_switches.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_switches.cc View 1 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
xiyuan
6 years, 3 months ago (2014-09-10 20:59:56 UTC) #2
Albert Bodenhamer
I'd kinda prefer to keep the flag but reverse its default behavior. We still have ...
6 years, 3 months ago (2014-09-10 21:33:32 UTC) #3
xiyuan
CL updated to use a disable flag instead of removing enable flag.
6 years, 3 months ago (2014-09-10 21:58:07 UTC) #4
Albert Bodenhamer
lgtm
6 years, 3 months ago (2014-09-10 22:04:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556403002/40001
6 years, 3 months ago (2014-09-11 22:24:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/13477)
6 years, 3 months ago (2014-09-12 00:58:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556403002/40001
6 years, 3 months ago (2014-09-12 01:04:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/13512) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/11812)
6 years, 3 months ago (2014-09-12 02:15:10 UTC) #13
xiyuan
Ilya, could I get an owner stamp for histograms.xml? Thanks.
6 years, 3 months ago (2014-09-12 03:26:17 UTC) #15
Ilya Sherman
Histograms LGTM % a nit: https://codereview.chromium.org/556403002/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/556403002/diff/60001/tools/metrics/histograms/histograms.xml#oldcode44626 tools/metrics/histograms/histograms.xml:44626: - <int value="2137347307" label="enable-drive-apps-in-app-list"/> ...
6 years, 3 months ago (2014-09-12 07:29:40 UTC) #16
xiyuan
https://codereview.chromium.org/556403002/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/556403002/diff/60001/tools/metrics/histograms/histograms.xml#oldcode44626 tools/metrics/histograms/histograms.xml:44626: - <int value="2137347307" label="enable-drive-apps-in-app-list"/> On 2014/09/12 07:29:40, Ilya Sherman ...
6 years, 3 months ago (2014-09-12 16:22:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556403002/80001
6 years, 3 months ago (2014-09-12 16:23:59 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 02d8753c6773164396d1ab1e646ffecce8cd9406
6 years, 3 months ago (2014-09-12 17:26:20 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 17:30:46 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/fde6f25b66d632e49751365559841c1e1c436856
Cr-Commit-Position: refs/heads/master@{#294610}

Powered by Google App Engine
This is Rietveld 408576698