Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: WebCore/page/Frame.cpp

Issue 5564003: Merge 72863 - Crash when iframe transfers from one page to another and has ch... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/597/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « WebCore/ChangeLog ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Simon Hausmann <hausmann@kde.org> 5 * 2000 Simon Hausmann <hausmann@kde.org>
6 * 2000 Stefan Schimanski <1Stein@gmx.de> 6 * 2000 Stefan Schimanski <1Stein@gmx.de>
7 * 2001 George Staikos <staikos@kde.org> 7 * 2001 George Staikos <staikos@kde.org>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
9 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com> 9 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 716 matching lines...) Expand 10 before | Expand all | Expand 10 after
727 727
728 m_page = newPage; 728 m_page = newPage;
729 729
730 if (newPage) 730 if (newPage)
731 newPage->incrementFrameCount(); 731 newPage->incrementFrameCount();
732 732
733 didTransfer = true; 733 didTransfer = true;
734 } 734 }
735 735
736 // Update the frame tree. 736 // Update the frame tree.
737 didTransfer = newParent->tree()->transferChild(this); 737 didTransfer = newParent->tree()->transferChild(this) || didTransfer;
738 738
739 // Avoid unnecessary calls to client and frame subtree if the frame ended 739 // Avoid unnecessary calls to client and frame subtree if the frame ended
740 // up on the same page and under the same parent frame. 740 // up on the same page and under the same parent frame.
741 if (didTransfer) { 741 if (didTransfer) {
742 // Let external clients update themselves. 742 // Let external clients update themselves.
743 loader()->client()->didTransferChildFrameToNewDocument(oldPage); 743 loader()->client()->didTransferChildFrameToNewDocument(oldPage);
744 744
745 // Update resource tracking now that frame could be in a different page. 745 // Update resource tracking now that frame could be in a different page.
746 if (oldPage != newPage) 746 if (oldPage != newPage)
747 loader()->transferLoadingResourcesFromPage(oldPage); 747 loader()->transferLoadingResourcesFromPage(oldPage);
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
975 document->recalcStyle(Node::Force); 975 document->recalcStyle(Node::Force);
976 976
977 if (FrameView* view = this->view()) { 977 if (FrameView* view = this->view()) {
978 if (document->renderer() && document->renderer()->needsLayout() && view- >didFirstLayout()) 978 if (document->renderer() && document->renderer()->needsLayout() && view- >didFirstLayout())
979 view->layout(); 979 view->layout();
980 view->setScrollPosition(origin); 980 view->setScrollPosition(origin);
981 } 981 }
982 } 982 }
983 983
984 } // namespace WebCore 984 } // namespace WebCore
OLDNEW
« no previous file with comments | « WebCore/ChangeLog ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698