Issue 556363002: DevTools: NetworkRequest: convert connectionId to string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 556363002: DevTools: NetworkRequest: convert connectionId to string (Closed)

Created:
6 years, 3 months ago by eustas

Modified:
6 years, 3 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: NetworkRequest: convert connectionId to string String is much more useful, it can be used as key for StringMap. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181763

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -3 lines)			Patch
M	Source/devtools/front_end/network/HAREntry.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/sdk/NetworkManager.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sdk/NetworkRequest.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/556363002/1

6 years, 3 months ago (2014-09-10 18:51:11 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 20:13:06 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 181763

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages