Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Issue 556323003: Calendar Picker: Make month popup cells non-focusable. (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Calendar Picker: Make month popup cells non-focusable. We used <button> for cells, and we had unexpected focus behaviors. This CL changes <button> to <div>. This is a preparation to support accessibility in the month popup. BUG=123896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M LayoutTests/fast/forms/calendar-picker/calendar-picker-key-operations.html View 2 chunks +21 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/resources/calendarPicker.css View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/web/resources/calendarPicker.js View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, would you review this please?
6 years, 3 months ago (2014-09-11 00:48:59 UTC) #2
keishi
lgtm
6 years, 3 months ago (2014-09-11 02:08:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556323003/1
6 years, 3 months ago (2014-09-11 02:22:58 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 02:26:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181781

Powered by Google App Engine
This is Rietveld 408576698