Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 556313003: [Android] Workaround for aarch64 NDK bug. (Closed)

Created:
6 years, 3 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, navabi1, rmcilroy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Workaround for aarch64 NDK bug. The last NDK roll (r10c-rc1) lost the ability of generating functional executables. This is a temporary workaround and should go away by the time r10c-rd3 NDK is rolled. BUG= Committed: https://crrev.com/df01991ea10e2d19a684e9a212a8b4390005ea64 Cr-Commit-Position: refs/heads/master@{#294257}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/common.gypi View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Primiano Tucci (use gerrit)
6 years, 3 months ago (2014-09-10 19:01:49 UTC) #2
Fabrice (no longer in Chrome)
lgtm
6 years, 3 months ago (2014-09-10 19:32:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/556313003/1
6 years, 3 months ago (2014-09-10 19:41:22 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-10 19:41:24 UTC) #7
Primiano Tucci (use gerrit)
+navabi for a stampty stamp!
6 years, 3 months ago (2014-09-10 20:27:11 UTC) #9
navabi1
lgtm
6 years, 3 months ago (2014-09-10 20:36:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/556313003/20001
6 years, 3 months ago (2014-09-10 21:02:04 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 2431a9768e8329bc5cfca6e85f413f918dede3e4
6 years, 3 months ago (2014-09-10 23:27:10 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 23:29:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df01991ea10e2d19a684e9a212a8b4390005ea64
Cr-Commit-Position: refs/heads/master@{#294257}

Powered by Google App Engine
This is Rietveld 408576698