Issue 5563005: Define IPC_USES_READWRITE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5563005: Define IPC_USES_READWRITE (Closed)

Created:
10 years ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Define IPC_USES_READWRITE Simplify debugging some Linux issues on the Mac by allowing Mac users to compile with IPC_USES_READWRITE set to 1 and pass file descriptors in the same manner that Linux does by default. Previously it was all controlled by #if !defined OS_MACOSX. BUG=none TEST=build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68636

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -18 lines)			Patch
	M	ipc/ipc_channel_posix.h	View		2 chunks	+22 lines, -1 line	0 comments	Download
	M	ipc/ipc_channel_posix.cc	View		9 chunks	+11 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages