Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 556293004: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
ben+ash_chromium.org, chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Committed: https://crrev.com/abee4fef8c6b2078294f65f678d2f41e928ad311 Cr-Commit-Position: refs/heads/master@{#294940}

Patch Set 1 #

Patch Set 2 : Revert pointless change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 3 months ago (2014-09-15 20:02:36 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-15 21:51:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556293004/20001
6 years, 3 months ago (2014-09-15 22:39:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as dfbcbbd3b0b439bf97c635d4e65e2b797047e183
6 years, 3 months ago (2014-09-16 00:31:25 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 00:40:02 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/abee4fef8c6b2078294f65f678d2f41e928ad311
Cr-Commit-Position: refs/heads/master@{#294940}

Powered by Google App Engine
This is Rietveld 408576698