chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h - Issue 556293003: Allow the user to drag an extension to the overflow menu, even when its empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h

Issue 556293003: Allow the user to drag an extension to the overflow menu, even when its empty (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/toolbar/browser_actions_container.cc ('K') | « chrome/browser/ui/views/toolbar/browser_actions_container.cc ('k') | chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc » ('j') | chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h

diff --git a/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h b/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h

index 91d7731d26c9d768ff5dc44f2918e231393057c8..cfd065207699dd1178a453b9ba39e31c01e52e10 100644

--- a/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h

+++ b/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h

@@ -25,6 +25,9 @@ class ExtensionToolbarMenuView : public views::View,

ExtensionToolbarMenuView(Browser* browser, WrenchMenu* wrench_menu);

virtual ~ExtensionToolbarMenuView();

+ // Returns true the wrench menu should show this view.

Peter Kasting 2014/09/16 21:40:55 Nit: true -> whether Consider explaining when thi

Devlin 2014/09/16 21:58:29 Done.

+ bool ShouldShow();

// views::View:

virtual gfx::Size GetPreferredSize() const OVERRIDE;

virtual int GetHeightForWidth(int width) const OVERRIDE;