Reorganize sandbox operator new, add a comment.

Reorganize sandbox operator new, add a comment.

Now that NT_PAGE is gone, rewrite the function to be single-return and add
a comment pointing out that what the function is doing is incomplete.

No intended behavior change, should fix 2 clang warnings of the form
..\..\sandbox\win\src\sandbox_nt_util.cc(560,3) :  warning(clang): 'operator new' should not return a null pointer unless it is declared 'throw()' or 'noexcept' [-Wnew-returns-null]
  return NULL;
  ^
BUG=82385
R=rvargas@chromium.org

Committed: https://crrev.com/a1cfce8ecf31c486bbb1307ebfb44a2a0c15d2cb
Cr-Commit-Position: refs/heads/master@{#294246}

[Nico, 2014-09-10 14:48:39]

thakis@chromium.org changed reviewers:
+ rvargas@chromium.org

[rvargas (doing something else), 2014-09-10 22:22:59]

lgtm

https://codereview.chromium.org/556293002/diff/40001/sandbox/win/src/sandbox_...
File sandbox/win/src/sandbox_nt_util.cc (right):

https://codereview.chromium.org/556293002/diff/40001/sandbox/win/src/sandbox_...
sandbox/win/src/sandbox_nt_util.cc:557: NOTREACHED_NT();
This is a change in behavior for debug builds :(

[Nico, 2014-09-10 22:24:28]

https://codereview.chromium.org/556293002/diff/40001/sandbox/win/src/sandbox_...
File sandbox/win/src/sandbox_nt_util.cc (right):

https://codereview.chromium.org/556293002/diff/40001/sandbox/win/src/sandbox_...
sandbox/win/src/sandbox_nt_util.cc:557: NOTREACHED_NT();
On 2014/09/10 22:22:58, rvargas wrote:
> This is a change in behavior for debug builds :(

Oh, you mean when type == NOT_ALLOC but InitHead() fails? Yes, that's true. I'll
make the InitHeap() call nested again, thanks for catching this.

[Nico, 2014-09-10 22:43:20]

Committed patchset #4 (id:60001) to pending queue manually as 9bd5561 (presubmit
successful).

[commit-bot: I haz the power, 2014-09-10 22:49:12]

Patchset 4 (id:??) landed as
https://crrev.com/a1cfce8ecf31c486bbb1307ebfb44a2a0c15d2cb
Cr-Commit-Position: refs/heads/master@{#294246}