In generated dictionary toImpl(), throw all exceptions via ExceptionState

Source/bindings/templates/dictionary_v8.cpp

Index: Source/bindings/templates/dictionary_v8.cpp
diff --git a/Source/bindings/templates/dictionary_v8.cpp b/Source/bindings/templates/dictionary_v8.cpp
index 77a6b3c6820616bc3cdd2b7bfdd68fdf3753957f..6991457484746831ba214547b1294513d215ee3d 100644
--- a/Source/bindings/templates/dictionary_v8.cpp
+++ b/Source/bindings/templates/dictionary_v8.cpp
@@ -19,6 +19,7 @@ namespace blink {
     // FIXME: Do not use Dictionary and DictionaryHelper
     // https://crbug.com/321462
     Dictionary dictionary(v8Value, isolate);
+    v8::TryCatch block;

[bashi, 2014/09/10 14:12:51]

Could you leave a FIXME comment so that I won't miss removing this?

[Jens Widell, 2014/09/10 14:26:46]

Done.

     {% for member in members %}
     {{member.cpp_type}} {{member.name}};
     if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "{{member.name}}", {{member.name}})) {
@@ -30,6 +31,9 @@ namespace blink {
         }
     {% endif %}
         impl->{{member.setter_name}}({{member.name}});
+    } else if (block.HasCaught()) {
+        exceptionState.rethrowV8Exception(block.Exception());
+        return 0;
     }
     {% endfor %}
     return impl;