Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 556243003: Make the private slot optional in NSSCertDatabase. (Closed)

Created:
6 years, 3 months ago by pneubeck (no reviews)
Modified:
6 years, 3 months ago
Reviewers:
stevenjb, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make the private slot optional in NSSCertDatabase. BUG=411927 Committed: https://crrev.com/ba249ef277f2fe628f82b8280f70491d0d4a535a Cr-Commit-Position: refs/heads/master@{#294438}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chromeos/cert_loader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/cert/nss_cert_database.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/cert/nss_cert_database.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pneubeck (no reviews)
ptal
6 years, 3 months ago (2014-09-11 08:34:46 UTC) #3
mattm
lgtm
6 years, 3 months ago (2014-09-11 17:45:57 UTC) #4
pneubeck (no reviews)
Steven, please owner review.
6 years, 3 months ago (2014-09-11 18:05:17 UTC) #6
stevenjb
lgtm
6 years, 3 months ago (2014-09-11 18:12:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556243003/20001
6 years, 3 months ago (2014-09-11 18:24:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 704709a54b137fd64b5b6ee2d9603d54e8d8316a
6 years, 3 months ago (2014-09-11 19:04:49 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 19:09:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba249ef277f2fe628f82b8280f70491d0d4a535a
Cr-Commit-Position: refs/heads/master@{#294438}

Powered by Google App Engine
This is Rietveld 408576698