Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 556223003: Let SkTaskGroup work synchronously if no one created an SkTaskGroup::Enabler. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Let SkTaskGroup work synchronously if no one created an SkTaskGroup::Enabler. Tested by running DM with its SkTaskGroup::Enabler commented out. Slow, but completed correctly. BUG=skia: Committed: https://skia.googlesource.com/skia/+/eefd18cef26dcfb67e68d05e1845b35f015a5bca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/utils/SkTaskGroup.cpp View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
6 years, 3 months ago (2014-09-12 16:28:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556223003/1
6 years, 3 months ago (2014-09-12 16:28:24 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-12 16:28:24 UTC) #5
reed1
lgtm
6 years, 3 months ago (2014-09-12 16:29:24 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 16:35:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as eefd18cef26dcfb67e68d05e1845b35f015a5bca

Powered by Google App Engine
This is Rietveld 408576698