Source/modules/notifications/Notification.h - Issue 556193002: Add NotificationOptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/Notification.h

Issue 556193002: Add NotificationOptions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@dic-webmidi

Patch Set: Pointers -> References Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/notifications/Notification.h

diff --git a/Source/modules/notifications/Notification.h b/Source/modules/notifications/Notification.h

index 74846fb0727952cce97f79713677b83bf66d3469..b368a530649cab61f2ed289dc06c6ab5568f508a 100644

--- a/Source/modules/notifications/Notification.h

+++ b/Source/modules/notifications/Notification.h

@@ -43,8 +43,8 @@

namespace blink {

-class Dictionary;

class ExecutionContext;

+class NotificationOptions;

class NotificationPermissionCallback;

class Notification : public RefCountedGarbageCollectedWillBeGarbageCollectedFinalized<Notification>, public ActiveDOMObject, public EventTargetWithInlineData {

@@ -52,7 +52,7 @@ class Notification : public RefCountedGarbageCollectedWillBeGarbageCollectedFina

DEFINE_WRAPPERTYPEINFO();

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Notification);

public:

- static Notification* create(ExecutionContext*, const String& title, const Dictionary& options);

+ static Notification* create(ExecutionContext*, const String& title, const NotificationOptions&);

virtual ~Notification();

« no previous file with comments | « Source/modules/modules.gypi ('k') | Source/modules/notifications/Notification.cpp » ('j') | no next file with comments »