Source/modules/notifications/Notification.idl - Issue 556193002: Add NotificationOptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/Notification.idl

Issue 556193002: Add NotificationOptions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@dic-webmidi

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/notifications/Notification.idl

diff --git a/Source/modules/notifications/Notification.idl b/Source/modules/notifications/Notification.idl

index 51a26d91389b216800714bb469b2a94f95d9dcf5..04a49ad1b69723df8a70e119aec44eb13c4cee0c 100644

--- a/Source/modules/notifications/Notification.idl

+++ b/Source/modules/notifications/Notification.idl

@@ -32,7 +32,7 @@

[

GarbageCollected,

ActiveDOMObject,

- Constructor(DOMString title, [Default=Undefined] optional Dictionary options),

+ Constructor(DOMString title, [Default=Undefined] optional NotificationOptions options),

Peter Beverloo 2014/09/10 14:30:34 What does [Default=Undefined] mean in this case? W

bashi 2014/09/10 15:02:01 Good catch! [Default=Undefined] should have been r

ConstructorCallWith=ExecutionContext,

RuntimeEnabled=Notifications,

] interface Notification : EventTarget {