chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc - Issue 556173002: Ensure incognito TestingProfiles are incognito for their whole lifetime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

Issue 556173002: Ensure incognito TestingProfiles are incognito for their whole lifetime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: respond to comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/account_chooser_model_unittest.cc ('k') | chrome/browser/ui/browser_command_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

index 5206a3e576bdc904a0d5e22de8d5634ef97eaaf8..2d64f64ff896dc8e8eff5290e1250fc4cbdcf241 100644

--- a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

@@ -240,14 +240,8 @@ TEST_F(BookmarkContextMenuControllerTest, MultipleFoldersWithURLs) {

// Tests the enabled state of open incognito.

TEST_F(BookmarkContextMenuControllerTest, DisableIncognito) {

- // Create an incognito Profile. It must be associated with the original

- // Profile, so that GetOriginalProfile() works as expected.

- TestingProfile::Builder builder;

- builder.SetIncognito();

- scoped_ptr<TestingProfile> testing_incognito = builder.Build();

- testing_incognito->SetOriginalProfile(profile_.get());

- TestingProfile* incognito = testing_incognito.get();

- profile_->SetOffTheRecordProfile(testing_incognito.PassAs<Profile>());

+ TestingProfile* incognito =

+ TestingProfile::Builder().BuildIncognito(profile_.get());

incognito->CreateBookmarkModel(true);

BookmarkModel* model = BookmarkModelFactory::GetForProfile(incognito);