chrome/browser/profiles/profile_manager_unittest.cc - Issue 556173002: Ensure incognito TestingProfiles are incognito for their whole lifetime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_manager_unittest.cc

Issue 556173002: Ensure incognito TestingProfiles are incognito for their whole lifetime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: respond to comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_internals_service_unittest.cc ('k') | chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_manager_unittest.cc

diff --git a/chrome/browser/profiles/profile_manager_unittest.cc b/chrome/browser/profiles/profile_manager_unittest.cc

index 4685581b5ad358d1bf932b468480bff2b720f862..e3bb94413a095dcdff2bf71cbc485497b0ba2ee6 100644

--- a/chrome/browser/profiles/profile_manager_unittest.cc

+++ b/chrome/browser/profiles/profile_manager_unittest.cc

@@ -760,13 +760,6 @@ TEST_F(ProfileManagerTest, LastOpenedProfilesDoesNotContainIncognito) {

static_cast<TestingProfile*>(profile_manager->GetProfile(dest_path1));

ASSERT_TRUE(profile1);

- // Incognito profiles should not be managed by the profile manager but by the

- // original profile.

- TestingProfile::Builder builder;

- builder.SetIncognito();

- scoped_ptr<TestingProfile> profile2 = builder.Build();

- profile1->SetOffTheRecordProfile(profile2.PassAs<Profile>());

std::vector<Profile*> last_opened_profiles =

profile_manager->GetLastOpenedProfiles();

ASSERT_EQ(0U, last_opened_profiles.size());