chrome/browser/content_settings/content_settings_pref_provider_unittest.cc - Issue 556173002: Ensure incognito TestingProfiles are incognito for their whole lifetime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

Issue 556173002: Ensure incognito TestingProfiles are incognito for their whole lifetime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: respond to comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/power/power_prefs_unittest.cc ('k') | chrome/browser/password_manager/password_manager_internals_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

diff --git a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

index 9ad8bfbe544b220ec2b028455a1fb93670b569d7..7e32cb78fc4bd0df96d8ce1f5a32192fc4ce0105 100644

--- a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

+++ b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

@@ -158,10 +158,8 @@ TEST_F(PrefProviderTest, Incognito) {

scoped_ptr<TestingProfile> profile = profile_builder.Build();

TestingProfile::Builder otr_profile_builder;

- otr_profile_builder.SetIncognito();

otr_profile_builder.SetPrefService(make_scoped_ptr(otr_prefs));

- scoped_ptr<TestingProfile> otr_profile(otr_profile_builder.Build());

- profile->SetOffTheRecordProfile(otr_profile.PassAs<Profile>());

+ otr_profile_builder.BuildIncognito(profile.get());

PrefProvider pref_content_settings_provider(regular_prefs, false);

PrefProvider pref_content_settings_provider_incognito(otr_prefs, true);