Ensure incognito TestingProfiles are incognito for their whole lifetime.

chrome/browser/search/hotword_service_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/field_trial.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/extension_service_test_base.h"
 #include "chrome/browser/extensions/test_extension_service.h"
@@ skipping 74 matching lines @@
     g_browser_process->SetApplicationLocale(new_locale);
 #endif
   }
 
  private:
   base::FieldTrialList field_trial_list_;
 };
 
 TEST_F(HotwordServiceTest, IsHotwordAllowedBadFieldTrial) {
   TestingProfile::Builder profile_builder;
-  TestingProfile::Builder otr_profile_builder;
-  otr_profile_builder.SetIncognito();
   scoped_ptr<TestingProfile> profile = profile_builder.Build();
-  scoped_ptr<TestingProfile> otr_profile = otr_profile_builder.Build();
 
   HotwordServiceFactory* hotword_service_factory =
       HotwordServiceFactory::GetInstance();
 
   // Check that the service exists so that a NULL service be ruled out in
   // following tests.
   HotwordService* hotword_service =
       hotword_service_factory->GetForProfile(profile.get());
   EXPECT_TRUE(hotword_service != NULL);
 
@@ skipping 10 matching lines @@
       hotword_internal::kHotwordFieldTrialName);
   EXPECT_TRUE(group ==hotword_internal::kHotwordFieldTrialDisabledGroupName);
   EXPECT_FALSE(HotwordServiceFactory::IsHotwordAllowed(profile.get()));
 
   // Set a valid locale with invalid field trial to be sure it is
   // still false.
   SetApplicationLocale(static_cast<Profile*>(profile.get()), "en");
   EXPECT_FALSE(HotwordServiceFactory::IsHotwordAllowed(profile.get()));
 
   // Test that incognito returns false as well.
-  EXPECT_FALSE(HotwordServiceFactory::IsHotwordAllowed(otr_profile.get()));
+  EXPECT_FALSE(HotwordServiceFactory::IsHotwordAllowed(
+      profile->GetOffTheRecordProfile()));
 }
 
 TEST_F(HotwordServiceTest, IsHotwordAllowedLocale) {
   TestingProfile::Builder profile_builder;
-  TestingProfile::Builder otr_profile_builder;
-  otr_profile_builder.SetIncognito();
   scoped_ptr<TestingProfile> profile = profile_builder.Build();
-  scoped_ptr<TestingProfile> otr_profile = otr_profile_builder.Build();
 
   HotwordServiceFactory* hotword_service_factory =
       HotwordServiceFactory::GetInstance();
 
   // Check that the service exists so that a NULL service be ruled out in
   // following tests.
   HotwordService* hotword_service =
       hotword_service_factory->GetForProfile(profile.get());
   EXPECT_TRUE(hotword_service != NULL);
 
@@ skipping 12 matching lines @@
   EXPECT_TRUE(HotwordServiceFactory::IsHotwordAllowed(profile.get()));
   SetApplicationLocale(static_cast<Profile*>(profile.get()), "en_us");
   EXPECT_TRUE(HotwordServiceFactory::IsHotwordAllowed(profile.get()));
   SetApplicationLocale(static_cast<Profile*>(profile.get()), "de_DE");
   EXPECT_TRUE(HotwordServiceFactory::IsHotwordAllowed(profile.get()));
   SetApplicationLocale(static_cast<Profile*>(profile.get()), "fr_fr");
   EXPECT_TRUE(HotwordServiceFactory::IsHotwordAllowed(profile.get()));
 
   // Test that incognito even with a valid locale and valid field trial
   // still returns false.
-  SetApplicationLocale(static_cast<Profile*>(otr_profile.get()), "en");
-  EXPECT_FALSE(HotwordServiceFactory::IsHotwordAllowed(otr_profile.get()));
+  Profile* otr_profile = profile->GetOffTheRecordProfile();
+  SetApplicationLocale(otr_profile, "en");
+  EXPECT_FALSE(HotwordServiceFactory::IsHotwordAllowed(otr_profile));
 }
 
 TEST_F(HotwordServiceTest, AudioLoggingPrefSetCorrectly) {
   TestingProfile::Builder profile_builder;
   scoped_ptr<TestingProfile> profile = profile_builder.Build();
 
   HotwordServiceFactory* hotword_service_factory =
       HotwordServiceFactory::GetInstance();
   HotwordService* hotword_service =
       hotword_service_factory->GetForProfile(profile.get());
@@ skipping 122 matching lines @@
   EXPECT_EQ("fr_fr",
             profile()->GetPrefs()->GetString(prefs::kHotwordPreviousLanguage));
 
   // If the locale is set back to the last valid one, then an uninstall-install
   // shouldn't be needed.
   SetApplicationLocale(profile(), "fr_fr");
   EXPECT_TRUE(HotwordServiceFactory::IsHotwordAllowed(profile()));
   EXPECT_FALSE(hotword_service->MaybeReinstallHotwordExtension());
   EXPECT_EQ(1, hotword_service->uninstall_count());  // no change
 }