Ensure incognito TestingProfiles are incognito for their whole lifetime.

chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 374 matching lines @@
 }
 
 class OneClickSigninHelperIncognitoTest : public OneClickSigninHelperTest {
  protected:
   // content::RenderViewHostTestHarness.
   virtual content::BrowserContext* CreateBrowserContext() OVERRIDE;
 };
 
 content::BrowserContext*
 OneClickSigninHelperIncognitoTest::CreateBrowserContext() {
-  // Builds an incognito profile to run this test.
-  TestingProfile::Builder builder;
-  builder.SetIncognito();
-  return builder.Build().release();
+  // Simulate an incognito profile to run this test. RenderViewHostTestHarness
+  // takes ownership of the return value, so it can't be a "proper" incognito
+  // profile, since they are owned by their parent, non-incognito profile.
+  scoped_ptr<TestingProfile> profile = TestingProfile::Builder().Build();
+  profile->ForceIncognito(true);
+  return profile.release();
 }

[tapted, 2014/09/12 07:54:08]

I didn't want to use `ForceIncognito` here, but it was getting complicated
without it. However, I've realised ForceIncognito isn't always to blame for the
problems in http://crbug.com/277296 . Instead it's the GetOriginalProfile()
mismatch while creating the incognito TestingProfile "properly", which this CL
is fixing.

 
 TEST_F(OneClickSigninHelperTest, CanOfferNoContents) {
   std::string error_message;
   EXPECT_FALSE(OneClickSigninHelper::CanOffer(
       NULL, OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
       "user@gmail.com", &error_message));
   EXPECT_EQ("", error_message);
   EXPECT_FALSE(OneClickSigninHelper::CanOffer(
       NULL, OneClickSigninHelper::CAN_OFFER_FOR_ALL,
       "user@gmail.com", &error_message));
@@ skipping 604 matching lines @@
   args.email = "foo@gmail.com";
   args.profile = profile();
   MockStarterWrapper* wrapper = new MockStarterWrapper(
       args, OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS);
   SetCookie("LSID=1234; domain=google.com; secure; httponly");
 
   EXPECT_CALL(*wrapper, DisplayErrorBubble(_));
   wrapper->Start();
   base::RunLoop().RunUntilIdle();
 }