Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 556143002: GN fixes to make webkit_unit_tests link on android (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

GN fixes to make webkit_unit_tests link on android Linux sometimes means android too. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M Source/core/BUILD.gn View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jamesr
6 years, 3 months ago (2014-09-10 04:14:56 UTC) #1
brettw
lgtm
6 years, 3 months ago (2014-09-10 04:15:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/556143002/1
6 years, 3 months ago (2014-09-10 04:16:12 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 06:32:35 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 181706

Powered by Google App Engine
This is Rietveld 408576698