Issue 556100: Remember to update the write barrier when storing into...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 556100: Remember to update the write barrier when storing into... (Closed)

Created:
10 years, 10 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Remember to update the write barrier when storing into the context in the full compiler.

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -9 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1	2 chunks	+10 lines, -3 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

Lasse Reichstein

This addresses all the problems, so I'll close http://codereview.chromium.org/552256 which won't be any better than ...

10 years, 10 months ago (2010-02-01 16:12:59 UTC) #3

Lasse Reichstein

I think you can remove the bailout code from full-codegen.cc. It only guards parameters that ...

10 years, 10 months ago (2010-02-01 16:15:32 UTC) #4

Kasper Lund

10 years, 10 months ago (2010-02-02 06:37:26 UTC) #5

Dropped in favor of http://codereview.chromium.org/569008