Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 556083004: Add hooks to get incognito profile. (Closed)

Created:
6 years, 3 months ago by Maria
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add hooks to get incognito profile. BUG=404836 Committed: https://crrev.com/bfa4f0998ac052eba4a5ae1b0ecf692a6b3b0d1a Cr-Commit-Position: refs/heads/master@{#294312}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update to non-static #

Patch Set 3 : Fix style #

Total comments: 9

Patch Set 4 : Addressed comments #

Patch Set 5 : Adding more methods #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java View 1 2 3 4 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_android.h View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_android.cc View 1 2 3 4 2 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 23 (7 generated)
Maria
6 years, 3 months ago (2014-09-10 00:30:14 UTC) #2
Ted C
https://codereview.chromium.org/556083004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java File chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java (right): https://codereview.chromium.org/556083004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java#newcode24 chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java:24: public static Profile getOffTheRecordProfile() { can we make these ...
6 years, 3 months ago (2014-09-10 00:34:37 UTC) #3
Maria
PTAL https://codereview.chromium.org/556083004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java File chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java (right): https://codereview.chromium.org/556083004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java#newcode24 chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java:24: public static Profile getOffTheRecordProfile() { On 2014/09/10 00:34:37, ...
6 years, 3 months ago (2014-09-10 06:28:03 UTC) #4
Mr4D (OOO till 08-26)
lgtm
6 years, 3 months ago (2014-09-10 13:54:48 UTC) #5
Ted C
https://codereview.chromium.org/556083004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java File chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java (right): https://codereview.chromium.org/556083004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java#newcode48 chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java:48: private static native Object nativeGetOffTheRecordProfile( these shouldn't be static ...
6 years, 3 months ago (2014-09-10 17:08:10 UTC) #6
Ted C
6 years, 3 months ago (2014-09-10 17:08:11 UTC) #7
Maria
https://codereview.chromium.org/556083004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java File chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java (right): https://codereview.chromium.org/556083004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java#newcode48 chrome/android/java/src/org/chromium/chrome/browser/profiles/Profile.java:48: private static native Object nativeGetOffTheRecordProfile( On 2014/09/10 17:08:10, Ted ...
6 years, 3 months ago (2014-09-10 17:17:55 UTC) #8
Ted C
lgtm
6 years, 3 months ago (2014-09-10 17:18:53 UTC) #9
Maria
Ted, I added two more methods for Profile. Can you take another quick look?
6 years, 3 months ago (2014-09-10 18:23:45 UTC) #10
Ted C
slgtm -- yay for a more legitimate profile object
6 years, 3 months ago (2014-09-10 18:25:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mariakhomenko@chromium.org/556083004/80001
6 years, 3 months ago (2014-09-10 18:38:27 UTC) #13
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-10 20:17:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mariakhomenko@chromium.org/556083004/80001
6 years, 3 months ago (2014-09-10 21:01:53 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556083004/100001
6 years, 3 months ago (2014-09-11 00:37:25 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:100001) as b0b7e2336efd5e9c99b84f9317f01c81e7314a9e
6 years, 3 months ago (2014-09-11 03:28:14 UTC) #22
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 03:36:39 UTC) #23
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/bfa4f0998ac052eba4a5ae1b0ecf692a6b3b0d1a
Cr-Commit-Position: refs/heads/master@{#294312}

Powered by Google App Engine
This is Rietveld 408576698