Issue 55603002: Move HasHTTPScheme to AutocompleteInput.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 55603002: Move HasHTTPScheme to AutocompleteInput. (Closed)

Created:
7 years, 1 month ago by Peter Kasting

Modified:
7 years, 1 month ago

Reviewers:
Mark P

CC:
chromium-reviews, James Su

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move HasHTTPScheme to AutocompleteInput. This was on AutocompleteProvider because only providers needed it, but I'm going to be calling this from OmniboxEditModel. In the abstract, it probably makes slightly more sense as a member of AutocompleteInput than AutocompleteProvider anyway. BUG=151044 TEST=none R=mpearson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232821

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -19 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_input.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_input.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_provider.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_provider.cc	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/autocomplete/history_provider.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark P

lgtm (sorry the delay; somehow I didn't notice this review until this week.) --mark

7 years, 1 month ago (2013-11-04 18:51:04 UTC) #2

Peter Kasting

7 years, 1 month ago (2013-11-04 22:28:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r232821 (presubmit successful).

Expand Messages | Collapse Messages