Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 556023: Merge 53291 - WebCore: Fix for crash with gradient on table cell. Pass the c... (Closed)

Created:
10 years, 11 months ago by Chris Evans
Modified:
9 years, 6 months ago
Reviewers:
Stephen White
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Merge 53291 - WebCore: Fix for crash with gradient on table cell. Pass the correct background object down to RenderBoxModelObject::paintFillLayerExtended(). This also allowed a rework of the fix to bug 18445 by passing the correct RenderObject from RenderBox::paintRootBoxDecorations() down to RenderBoxModelObject::paintFillLayerExtended(). https://bugs.webkit.org/show_bug.cgi?id=28426 Reviewed by mitz@webkit.org. Covered by new layout test: LayoutTests/fast/gradients/crashontr.html * rendering/RenderBox.cpp: (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer): * rendering/RenderBox.h: Plumb through the correct background RenderObject. * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use the passedin background RenderObject (if present) when painting background images. Remove the previous fix for bug 18445. * rendering/RenderBoxModelObject.h: Plumb through the correct background RenderObject. * rendering/RenderTableCell.cpp: Pass in the correct backgroundObject to paintFillLayers(). (WebCore::RenderTableCell::paintBackgroundsBehindCell): LayoutTests: New layout test added to exercise fix for bug http://bugs.webkit.org/show_bug.cgi?id=28426 Reviewed by mitz@webkit.org. * fast/gradients/crashontrexpected.txt: Added. * fast/gradients/crashontr.html: Added. TBR=senorblanco@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -26 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/gradients/crash-on-tr.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/gradients/crash-on-tr-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +29 lines, -0 lines 0 comments Download
M WebCore/rendering/RenderBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M WebCore/rendering/RenderBox.cpp View 3 chunks +8 lines, -7 lines 0 comments Download
M WebCore/rendering/RenderBoxModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M WebCore/rendering/RenderBoxModelObject.cpp View 2 chunks +2 lines, -15 lines 0 comments Download
M WebCore/rendering/RenderTableCell.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Evans
10 years, 11 months ago (2010-01-26 19:10:44 UTC) #1
Stephen White
10 years, 11 months ago (2010-01-26 19:18:14 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698