[Profiles] Improve the display name for default profiles.

[Profiles] Improve the display name for default profiles.

If a profile is signed in, but has a default name (because this is after
enabling the new profiles UI but the Gaia profile name hasn't been downloaded)
display the email address rather than the default profile name.
It's one step better.

BUG=412809
TEST=Start Chrome with an empty user data dir and
--disable-new-avatar-menu. Create two profiles, and sign one of them in
with a profile that has a clean sync (or reset the sync data after signin).
Make sure that the last active profile is the *not* signed in one
(so close all the browser windows for the signed in profile). Restart Chrome
with --enable-new-avatar-menu. You should be in the local profile. Choose "Switch
person" from the avatar menu. The user manager should display the other profile's
email address in the pod. Once you launch that profile, the name should update to
the gaia name.

Committed: https://crrev.com/c929946b5b10c2cbaadfa49cd713da3c4e439ac5
Cr-Commit-Position: refs/heads/master@{#295166}

[noms (inactive), 2014-09-15 20:02:48]

noms@chromium.org changed reviewers:
+ rlp@chromium.org

[noms (inactive), 2014-09-15 20:02:49]

Moar better default profile names! :)

[rpetterson, 2014-09-16 19:05:02]

lgtm

https://codereview.chromium.org/556003007/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_manager_unittest.cc (right):

https://codereview.chromium.org/556003007/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_manager_unittest.cc:1233: // Adding a Gaia name
to a profile that previous had a default name should
typo: previously

[noms (inactive), 2014-09-16 21:08:05]

noms@chromium.org changed reviewers:
+ asvitkine@chromium.org

[noms (inactive), 2014-09-16 21:08:06]

+ alexei for the cocoa unit test.

https://codereview.chromium.org/556003007/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_manager_unittest.cc (right):

https://codereview.chromium.org/556003007/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_manager_unittest.cc:1233: // Adding a Gaia name
to a profile that previous had a default name should
On 2014/09/16 19:05:02, rpetterson wrote:
> typo: previously

Done.

[Alexei Svitkine (slow), 2014-09-16 21:08:57]

lgtm

[noms (inactive), 2014-09-16 21:09:30]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-09-16 21:11:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/556003007/20001

[commit-bot: I haz the power, 2014-09-16 22:55:39]

Committed patchset #2 (id:20001) as d0667d67b272799eb93569051f51ed7f11961913

[commit-bot: I haz the power, 2014-09-16 22:56:13]

Patchset 2 (id:??) landed as
https://crrev.com/c929946b5b10c2cbaadfa49cd713da3c4e439ac5
Cr-Commit-Position: refs/heads/master@{#295166}