content/browser/service_worker/service_worker_registration.cc - Issue 556003006: [ServiceWorker] Check is_uninstalled in ServiceWorkerRegisterJob::ContinueWithRegistration()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.cc

Issue 556003006: [ServiceWorker] Check is_uninstalled in ServiceWorkerRegisterJob::ContinueWithRegistration() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move is_uninstalled_ = true; Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/service_worker/service_worker_registration.cc

diff --git a/content/browser/service_worker/service_worker_registration.cc b/content/browser/service_worker/service_worker_registration.cc

index 5f995607c01b5db8cd1584a5efbf2b34b844feb5..c99efc89ceb7d5c4c03087c75bf6106c1bad0a67 100644

--- a/content/browser/service_worker/service_worker_registration.cc

+++ b/content/browser/service_worker/service_worker_registration.cc

@@ -30,6 +30,7 @@ ServiceWorkerRegistration::ServiceWorkerRegistration(

registration_id_(registration_id),

is_deleted_(false),

is_uninstalling_(false),

+ is_uninstalled_(false),

should_activate_when_ready_(false),

context_(context) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

@@ -287,6 +288,7 @@ void ServiceWorkerRegistration::OnDeleteFinished(

void ServiceWorkerRegistration::Clear() {

is_uninstalling_ = false;

+ is_uninstalled_ = true;

if (context_)

context_->storage()->NotifyDoneUninstallingRegistration(this);

« no previous file with comments | « content/browser/service_worker/service_worker_registration.h ('k') | no next file » | no next file with comments »