Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 556003005: Introduce GetBackendFromContextId to avoid using list index. (Closed)

Created:
6 years, 3 months ago by achuithb
Modified:
6 years, 3 months ago
Reviewers:
nednguyen, tbarzic
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Introduce GetBackendFromContextId to avoid using list index. BUG=398467 TEST=ExtensionTest Committed: https://crrev.com/a1a83005087fdac70e7809f9dc1d89f6c4f88dfc Cr-Commit-Position: refs/heads/master@{#294455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/extension_backend.py View 1 chunk +3 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
achuithb
Updated your CL with the changes to AllExtensionsLoaded()
6 years, 3 months ago (2014-09-11 11:49:53 UTC) #2
achuithb
6 years, 3 months ago (2014-09-11 11:52:40 UTC) #4
nednguyen
On 2014/09/11 11:52:40, achuithb wrote: Lgtm
6 years, 3 months ago (2014-09-11 13:45:22 UTC) #5
achuithb
On 2014/09/11 13:45:22, nednguyen wrote: > On 2014/09/11 11:52:40, achuithb wrote: > > Lgtm ty
6 years, 3 months ago (2014-09-11 13:54:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556003005/1
6 years, 3 months ago (2014-09-11 13:55:54 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-11 19:58:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556003005/1
6 years, 3 months ago (2014-09-11 20:07:48 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6d02af6f42731c3ac203dbff39e1df07590e7155
6 years, 3 months ago (2014-09-11 20:23:49 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a1a83005087fdac70e7809f9dc1d89f6c4f88dfc Cr-Commit-Position: refs/heads/master@{#294455}
6 years, 3 months ago (2014-09-11 20:35:06 UTC) #14
nednguyen
6 years, 3 months ago (2014-09-16 01:29:44 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/573573003/ by nednguyen@google.com.

The reason for reverting is: It looks like the moto E perf bots are broken due
to this change.
.

Powered by Google App Engine
This is Rietveld 408576698