[telemetry] Use consistent bucket naming.

tools/perf/page_sets/PRESUBMIT.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 import sys
 
 
 def LoadSupport(input_api):
@@ skipping 64 matching lines @@
     if not os.path.exists(file_path):
       results.append(output_api.PresubmitError(
           'Hash file exists, but file not found: %s' % hash_path))
       continue
     if cloud_storage.CalculateHash(file_path) != file_hash:
       results.append(output_api.PresubmitError(
           'Hash file does not match file\'s actual hash: %s' % hash_path))
       continue
 
     try:
-      bucket_input = raw_input('Uploading to Cloud Storage: %s\n'
-                               'Is this file [P]ublic or Google-[i]nternal?'
-                               % file_path).lower()
-      if 'public'.startswith(bucket_input):
+      bucket_input = raw_input(

[tonyg, 2014/09/10 00:15:01]

Just a thought, but it looks like we could auto-generate this whole block based
on BUCKET_ALIASES. Up to you.

[dtu, 2014/09/12 02:39:15]

Done.

+          'Uploading to Cloud Storage: %s\n'
+          'Which bucket should this go in? (public, partner, internal) '
+          % file_path).lower()
+      if bucket_input == 'public':
         bucket = cloud_storage.PUBLIC_BUCKET
-      elif ('internal'.startswith(bucket_input) or
-            'google-internal'.startswith(bucket_input)):
+      elif bucket_input == 'partner':
+        bucket = cloud_storage.PARTNER_BUCKET
+      elif bucket_input == 'internal':
         bucket = cloud_storage.INTERNAL_BUCKET
       else:
         results.append(output_api.PresubmitError(
-            'Response was neither "public" nor "internal": %s' % bucket_input))
+            '"%s" was not "public," "partner," or "internal"' % bucket_input))
         return results
 
       cloud_storage.Insert(bucket, file_hash, file_path)
       results.append(output_api.PresubmitNotifyResult(
           'Uploaded file to Cloud Storage: %s' % file_path))
     except cloud_storage.CloudStorageError, e:
       results.append(output_api.PresubmitError(
           'Unable to upload to Cloud Storage: %s\n\n%s' % (file_path, e)))
 
   return results
@@ skipping 22 matching lines @@
   return input_api.AffectedFiles(file_filter=_IsNewJsonPageSet)
 
 def CheckChangeOnUpload(input_api, output_api):
   results = _SyncFilesToCloud(input_api, output_api)
   return results
 
 
 def CheckChangeOnCommit(input_api, output_api):
   results = _VerifyFilesInCloud(input_api, output_api)
   return results